Repository navigation
Thermo: faithful Bennett statement on an enumerated fibre - #372
Merged
Merged
Conversation
A statement-level review (2026-11-09) compared the ledger, Smoke.agda comments and module headers with the statements they describe. This commit changes comments, ledger text and labels only; no proof term changes, and every theorem name and Smoke pin is kept. Vacuous or hypothesis-restating results, now labelled as such: - EchoThermodynamicsArbitrary.bennett-reversible-arbitrary: the injectivity hypothesis is unused; the cost is 0 for every f. - EchoDeniability.partial-deniable-restricted: restates its hypothesis. - NotResourceInstance.measure-not-injective: conditional, not "every measure is lossy". Overclaims corrected: - PROOF-STATUS "Pillars A–D COMPLETE" restated the claims R-2026-05-18 withdrew (graded-comonad laws, terminal-cone UP, model-independence, conservativity metatheorem). - EchoAbstractionBarrier (no enforced barrier; Echo is a transparent Σ), EchoEntropy (blind by construction), EchoLLEncoding (propositional carriers only), F5 (existence of the comparison iso, not uniqueness), EchoVariance/F1 Smoke comments (no graded monad, no adjunction; F1 is a lossless writer that does not mention Echo), EchoProvenance (the Echo-vs-Σ clearance does not hold), ImageFactorizationProp (conditional on a TruncInterface the --safe build does not supply). - Stale names and notes: const-fibre-↔-domain, aggregate-non-injective, F5-3 "final open slice", All.agda "scaffold" labels, σ–π "set equality", MAP.adoc CNO module list. PROOF-STATUS gains a "Design audit (2026-11-09)" table and records that every theorem is `ungraded` under PROOF-POLICY §8 (no PWG-3 receipt in repo; no Rocq/Lean leg). Checked: All, Smoke and AuditSmoke compile under `--safe --without-K --cubical-compatible` with the pinned toolchain (Agda 2.7.0.1, stdlib 8326c74, absolute-zero f486c29, via scripts/setup-agda.sh); kernel-guard, check-agda-invocations, check-no-unsafe and tools/check-guardrails.sh pass. Local, not a CI receipt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MF5GeeBBDF6sUzr6pZTjWV
bennett-reversible-arbitrary keyed its cost on fibre occupancy (0 or 1), so the cost was 0 for every map and the injectivity hypothesis was unused (2026-11-09 audit). It is kept, marked deprecated. New, in EchoThermodynamicsArbitrary: - FiberEnum f y: a list of preimages of y that contains every echo's domain point and has no repeats; enumerated-erasure-cost = Landauer bound on its length. No finiteness of the domain is assumed. - bennett-enumerated: injective ⇒ cost 0 (inj is what proves it) - landauer-fan-in: two distinct preimages ⇒ cost ≥ k·T - collapse-enum / collapse-erasure-cost: Bool → ⊤ costs exactly T - bennett-enumerated-cno-identity at the identity on Program Pinned in Smoke.agda; PROOF-STATUS and STABILITY_ANALYSIS updated, and the latter no longer calls the identity-map instance a CNO result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MF5GeeBBDF6sUzr6pZTjWV
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
hyperpolymath
marked this pull request as ready for review
November 9, 2026 15:37
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #369 (the claims audit). Merge that first; this PR then shows only
51cfb9c.Why
EchoThermodynamicsArbitrary.bennett-reversible-arbitrarypriced erasure by fibre occupancy (0 or 1), and⌊log₂⌋of either is 0. So the cost was 0 for every map, including the non-injective Boolean collapse, and the injectivity hypothesis was never used. The 2026-11-09 audit labelled it vacuous.What this adds
FiberEnum f y. An enumeration of the fibre: a list of preimages ofythat contains every echo's domain point and has no repeats.enumerated-erasure-costis the Landauer bound on its length. Only the fibre overyis enumerated; the domain may be infinite.bennett-enumerated. Injective ⇒ cost 0.injis exactly what rules out a second element.landauer-fan-in. Two distinct preimages ⇒ cost ≥ k·T, for any enumeration.collapse-enum/collapse-erasure-cost.Bool → ⊤costs exactly T, so the cost is not trivially 0.bennett-enumerated-cno-identity. The faithful form at the identity onProgram.bennett-reversible-arbitrarykeeps its type and is marked deprecated. All new names are pinned inSmoke.agda.PROOF-STATUS.adocmarks the audit row resolved.docs/STABILITY_ANALYSIS.adocno longer calls the identity-map instance a CNO result.Checks
On Agda 2.7.0.1 with stdlib 2.3 and the pinned absolute-zero (
f486c29), all under--safe --without-K --cubical-compatible:All.agdaandSmoke.agdapass.kernel-guard.sh,check-agda-invocations.shandcheck-no-unsafe.shpass.No postulates. This file keeps its
--safe --without-Kpragma: it importsCNO, and the pinned absolute-zero does not yet declare--cubical-compatible(hyperpolymath/absolute-zero#199 adds it).Generated by Claude Code